GitLab

Let live deprecated APIs for longer unless they are really problematic.

FIX

Fix tracepoint features init when the custom enable function does not
succeed. It used to still register the tracepoint, leading to the probe
assuming setup has been done when it has not. Instead, only register the
tracepoint if the enable function succeeded.

Refactor so that it's possible to create the tracepoint-based
enable/disable functions without defining the feature. This would allow
features using tracepoints among other things to reuse the
registering/deregistering logic.

Use make -j in order to speedup module build.

Revert to devlib master

remote: https://github.com/ARM-Software/devlib.git

1196e336a version: bump minor version number
f525374fb version: perform additional revision release
42e62aed5 target: Fix AndroidTarget pickling
f5cfcafb0 shutils: Remove shebang
7853d2c85 target: Run shutils.in in busybox
REVERT: 7866086ec shutils: Remove shebang
REVERT: 734b24987 target: Run shutils.in in busybox
REVERT: 23f663d14 target: Fix AndroidTarget pickling
REVERT: 235422855 devlib: Use async Target API
REVERT: be593120a target: Expose Target(max_async=50) parameter
REVERT: bec2c02fd target: Enable async methods
REVERT: fba315e76 utils/async: Add new utils.async module
REVERT: 981b69ff9 setup.py: Require Python >= 3.7
REVERT: 49e452046 setup.py: cleanup dependencies in setup.py
REVERT: d0b5c1a2a target: Make __getstate__ more future-proof
REVERT: dcfc28e3f target: Fix Target.get_connection()'s busybox
REVERT: 16c3f0e98 utils.misc: Make nullcontext work with asyncio

git-subtree-dir: external/devlib
git-subtree-split: 1196e336a5c014f843a496be70f41b0e6015c80f

FIX

The async branch seems to have an issue and connections detection stalls
on Pixel 6 stock image, so let's revert to devlib master for now until
the issue is better understood.

FIX

Turn make variables into strings early in the processing to avoid any
issues if they come from Python or YAML as other types.

FEATURE

When the "features" kernel module parameter is not specified, do not
fail the module load in case some features fail to enable. This allows
enabling as many features as possible, which is likely what the user
expects.

If features were manually selected, we still fail the module load so the
user can rely on having the features they asked for or an obvious error.

Instead of bailing out at the first feature that fails to enable, enable
all the features we can and report the issue at the end.

FIX

When a feature fails to enable, record the return code and serve it
again to any other dependent feature when they try to enable it.

Previously, later attempts to enable would return 0, and the dependent
feature would think the feature is enabled and ready for use.

FIX

Make autogroup_path() static so that the helper can be included in more
than one compilation unit.

Document that the "name" key defaults to the value of "tip" if not
provided for a cherry-pick topic.

Topic names must be unique for correct operations so ensure that it is
the case in practice.

FIX

Fix tag action that were resulting in an exception: KeyError: 'tip'

FIX

The copy overlay backend was not able to restore the deleted state of a
file when an upper was reused as a lower, like overlayfs is able to
using whiteout.

Fix that by only restoring the top-most lower layer when using the copy
backemd. This also has the advantage of speeding up the re-use of lowers
as only one tree needs to be copied.

After this change, lowers created with one backend cannot be mixed with
lowers created by another backend, so add the backend to the cache key
where appropriate.

FEATURE

Use rsync when available in order to speedup the copy, as rsync is much
faster than shutil.copytree() Python function.

Speedup the copy overlay backend.

FIX

Logging directly or indirectly inside a destructor (__del__) is
problematic as they are invoked when the world is breaking down around
them, which can trigger some harmless exceptions. For this reason,
get_logger() was returning a dummy logger if __del__ was found in the
stack.

inspect.stack() is unfortunately really slow (150ms to get a stack frame
of depth 25), which is enough to really slowdown the import of some
modules and runtime code as well.

Fix that by returning a wrapped logger object that will only inpsect the
stack if an exception is raised.

FIX

Ensure the workload is cleaned during the method call, so that we don't
try to interact with the target when the interpreter is shutting down.

FIX

Parse the "pid" field as a int32 instead of uint32, as -1 is used when
the described entity is not a task.

Defer the import of lisa.analysis submodules to the point where we need
to know about the TraceAnalysisBase subclasses and not before.

Remove topics that have been merged upstream.

Use devlib fork

7866086ec shutils: Remove shebang
734b24987 target: Run shutils.in in busybox
23f663d14 target: Fix AndroidTarget pickling
235422855 devlib: Use async Target API
be593120a target: Expose Target(max_async=50) parameter
bec2c02fd target: Enable async methods
fba315e76 utils/async: Add new utils.async module
981b69ff9 setup.py: Require Python >= 3.7
49e452046 setup.py: cleanup dependencies in setup.py
d0b5c1a2a target: Make __getstate__ more future-proof
dcfc28e3f target: Fix Target.get_connection()'s busybox
16c3f0e98 utils.misc: Make nullcontext work with asyncio

git-subtree-dir: external/devlib
git-subtree-split: 7866086eccdc9781df2a806a05e7424723cb9d8d

remote: https://github.com/douglas-raillard-arm/devlib.git

FIX

Distinguish between failures in git cherry-pick --continue:
* If the cherry picking is finished, the topic is rebased and there is
  no issue.
* Otherwise, that indicates further conflicts in the topic that need
  fixing as well.

Before this patch, batch-rebase would just silently drop the commits
after the 2nd conflict in a topic.

FEATURE

If "name" is not provided for a topic, it will default to the value of
the "tip" key.

FEATURE

Make the rr-cache key optional if no external rr-cache is needed.

Use a fork of devlib in order to make fixes more available more quickly
to the end user. Each commit in this branch are submitted in upstream
devlib as well.

Allow a large number of concurrent connections so that devlib can take
advantage of it.

FIX

libbtf fails to detect pointer size correctly in BTF output by clang.
Fix libbtf and add the branch to the pahole's manifest.

FIX

--forward_decl dumps the forward declaration of every type in the
kernel. Unfortunately, some android kernels redefine the same type
multiple times (struct map_info/union map_info) leading to an invalid
header.

Instead of using this pahole option, use sed to generate the
declarations of just the types used in the header.

FIX

The log entry claimed the user did not set CROSS_COMPILE
unconditionally. Rephrase to avoid that, since CROSS_COMPILE is read and
chewed by LISA anyway.

Use --show_only_data_members to avoid having useless anonymous type
declaration in the middle of e.g. a struct.

Consider the following type:

    struct foo {
       struct { int a; } bar;
    };

GCC emits DWARF info looking this way:

    DW_TAG_structure_type
        DW_AT_name "foo"
        DW_TAG_member
            DW_AT_name "bar"
            DW_AT_type "struct "
            DW_AT_data_member_location <0x42 - curr_loc>
       NULL

    0x42:
    DW_TAG_structure_type
        DW_TAG_member
            DW_AT_name "a"
            DW_AT_type "int "
            DW_AT_data_member_location ...
        NULL

Clang emits:

    DW_TAG_structure_type
        DW_AT_name "foo"
        DW_TAG_member
            DW_AT_name "bar"
            DW_AT_type "struct "
            DW_AT_data_member_location 0x0

        DW_TAG_structure_type
            DW_TAG_member
                DW_AT_name "a"
                DW_AT_type "int "
                DW_AT_data_member_location ...
            NULL
        NULL

When pahole sees clang's output, it will emit something like that:

    struct foo {
       struct { int a; }; <------useless
       struct { int a; } bar;
    };

But with --show_only_data_members, it will ignore any child of
DW_TAG_structure_type that is not a DW_TAG_member and will print the
expected code.

FEATURE

LLVM=1 implies CC=clang, so make LISA recognize that.
Additionally, recognize e.g. LLVM=-14 as a clang version and detect the
toolchain accordingly.