Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
  • Sign in
  • S SCP-firmware
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Locked Files
  • Issues 10
    • Issues 10
    • List
    • Boards
    • Service Desk
    • Milestones
    • Iterations
    • Requirements
  • Merge requests 7
    • Merge requests 7
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
    • Test Cases
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Container Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Code review
    • Insights
    • Issue
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • Firmware
  • SCP-firmware
  • Merge requests
  • !444

scmi: fix psci protocol-count assertions

  • Review changes

  • Download
  • Email patches
  • Plain diff
Open Darryl Green requested to merge github/fork/yaronm-hailo/fix-mod_scmi-psci-protocol-count-assertions into master Mar 18, 2021
  • Overview 4
  • Commits 1
  • Pipelines 1
  • Changes 1

Created by: HelloGravity

I got assertion errors when trying to work with mod_scmi with a PSCI agent with protocol_count=0.

It turned out the assertion itself has a bug, it does not allow scmi_ctx.protocol_count to be equal to scmi_ctx.config->dis_protocol_count_psci.

The reason for the assertion is so that the subtraction scmi_ctx.protocol_count - scmi_ctx.config->dis_protocol_count_psci would not be negative. But no reason it cannot be 0.

It worked after fixing these 2 assertions.

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: github/fork/yaronm-hailo/fix-mod_scmi-psci-protocol-count-assertions