Skip to content
GitLab
Projects Groups Topics Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
  • Sign in
  • S SCP-firmware
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributor statistics
    • Graph
    • Compare revisions
    • Locked files
  • Issues 10
    • Issues 10
    • List
    • Boards
    • Service Desk
    • Milestones
    • Iterations
    • Requirements
  • Merge requests 7
    • Merge requests 7
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Artifacts
    • Schedules
    • Test cases
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Container Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • CI/CD
    • Code review
    • Insights
    • Issue
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • Firmware
  • SCP-firmware
  • Merge requests
  • !482

Fix to protect fwk_signal_ctx from interrupts

  • Review changes

  • Download
  • Patches
  • Plain diff
Merged Darryl Green requested to merge github/fork/mhiramat/master into master Jun 07, 2021
  • Overview 5
  • Commits 1
  • Pipelines 0
  • Changes 1

Created by: mhiramat

Since fwk_process_signal() enable global interrupt before updating fwk_signal_ctx.pending_signals, there can race with the increment operation in fwk_thread_put_signal(). Call fwk_interrupt_global_enable() after updating the fwk_signal_ctx, so that it can be protected by fwk_thread_put_signal().

Reported-by: Kazuhiko Sakamoto sakamoto.kazuhiko@socionext.com Signed-off-by: Masami Hiramatsu masami.hiramatsu@linaro.org

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: github/fork/mhiramat/master