Skip to content
Snippets Groups Projects

Multiple cases of explicit type casting unsigned int(uint32_t) to int

Closed Darryl Green requested to merge github/fork/Sanchit-kumar/issue_783 into master

Created by: Sanchit-kumar

Fixes #783 (closed)

Merge request reports

Approval is optional

Closed by (Jan 8, 2025 3:05pm UTC)

Merge details

  • The changes were not merged into .

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Author Contributor

    Created by: ssg-bot

    Can one of the admins verify this patch?

  • Author Contributor

    Created by: leandro-arm

    Review: Changes requested

    Hi @Sanchit-kumar, could you please sign off your patch and explain the reason of this change? Thanks

  • Author Contributor

    Created by: Sanchit-kumar

    Signed off patch with explanation along with the code style violation change commit.

  • Author Contributor

    Created by: nicola-mazzucato-arm

    Review: Changes requested

    I am not sure to understand. This change looks like a code-style update to me, rather than a type casting. Can you please clarify better where the issue is? Thanks

  • Author Contributor

    Created by: Sanchit-kumar

    I am not sure to understand. This change looks like a code-style update to me, rather than a type casting. Can you please clarify better where the issue is? Thanks

    Sure. Please recheck the following lines w.r.t updated file in pull request::

    Changed data type: Line No. 349, 350 Removed explicit type casting to int: Line no. 398, 399, 410, 411,421, 422, 433, 434, 446, 447, 459, 460 475

    Specially I would like to point out line no. 399, 411, 422, 434, 447, 460 where resource_ size is directly assigned with the value of unsigned int member variables of structure variable sources_perms_ctx (e.g., pd_count, clock_count etc) by explicitly type cast to int.

    Thanks

  • Author Contributor

    Created by: nicola-mazzucato-arm

    @Sanchit-kumar sorry for the late reply. Can you please tidy up the patches. In particular, there's a merge branch commit which will need to be removed, before potentially merge the PR. Thanks

Please register or sign in to reply