Skip to content
GitLab
  • Menu
Projects Groups Snippets
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
  • Sign in
  • L linux-coresight-backports
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Locked Files
  • Issues 0
    • Issues 0
    • List
    • Boards
    • Service Desk
    • Milestones
    • Iterations
    • Requirements
  • Merge requests 0
    • Merge requests 0
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
    • Test Cases
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages & Registries
    • Packages & Registries
    • Container Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Code review
    • Insights
    • Issue
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • linux-arm
  • linux-coresight-backports
  • Repository
Switch branch/tag
  • linux-coresight-backports
  • drivers
  • gpu
  • drm
  • i915
  • gem
  • i915_gem_busy.c
Find file BlameHistoryPermalink
  • Tvrtko Ursulin's avatar
    drm/i915: Align engine->uabi_class/instance with i915_drm.h · 5eec7182
    Tvrtko Ursulin authored Jan 16, 2020
    
    
    In our ABI we have defined I915_ENGINE_CLASS_INVALID_NONE and
    I915_ENGINE_CLASS_INVALID_VIRTUAL as negative values which creates
    implicit coupling with type widths used in, also ABI, struct
    i915_engine_class_instance.
    
    One place where we export engine->uabi_class
    I915_ENGINE_CLASS_INVALID_VIRTUAL is from our our tracepoints. Because the
    type of the former is u8 in contrast to u16 defined in the ABI, 254 will
    be returned instead of 65534 which userspace would legitimately expect.
    
    Another place is I915_CONTEXT_PARAM_ENGINES.
    
    Therefore we need to align the type used to store engine ABI class and
    instance.
    
    v2:
     * Update the commit message mentioning get_engines and cc stable.
       (Chris)
    Signed-off-by: default avatarTvrtko Ursulin <tvrtko.ursulin@intel.com>
    Fixes: 6d06779e
    
     ("drm/i915: Load balancing across a virtual engine")
    Cc: Chris Wilson <chris@chris-wilson.co.uk>
    Cc: <stable@vger.kernel.org> # v5.3+
    Reviewed-by: default avatarChris Wilson <chris@chris-wilson.co.uk>
    Link: https://patchwork.freedesktop.org/patch/msgid/20200116134508.25211-1-tvrtko.ursulin@linux.intel.com
    
    
    (cherry picked from commit 0b3bd0cdc329a1e2e00995cffd61aacf58c87cb4)
    Signed-off-by: default avatarJoonas Lahtinen <joonas.lahtinen@linux.intel.com>
    5eec7182