Skip to content
  • Kees Cook's avatar
    treewide: devm_kzalloc() -> devm_kcalloc() · a86854d0
    Kees Cook authored
    The devm_kzalloc() function has a 2-factor argument form, devm_kcalloc().
    This patch replaces cases of:
            devm_kzalloc(handle, a * b, gfp)
            devm_kcalloc(handle, a * b, gfp)
    as well as handling cases of:
            devm_kzalloc(handle, a * b * c, gfp)
            devm_kzalloc(handle, array3_size(a, b, c), gfp)
    as it's slightly less ugly than:
            devm_kcalloc(handle, array_size(a, b), c, gfp)
    This does, however, attempt to ignore constant size factors like:
            devm_kzalloc(handle, 4 * 1024, gfp)
    though any constants defined via macros get caught up in the conversion.
    Any factors with a sizeof() of "unsigned char", "char", and "u8" were
    dropped, since they're redundant.
    Some manual whitespace fixes were needed in this patch, as Coccinelle
    really liked to write "=devm_kcalloc..." instead of "= devm_kcalloc...".
    The Coccinelle script used for this was:
    // Fix redundant parens around sizeof().
    expression HANDLE;
    type TYPE;