Skip to content
  • Andrew Gabbasov's avatar
    usb: gadget: f_fs: Fix use-after-free in ffs_free_inst · cdafb6d8
    Andrew Gabbasov authored
    KASAN enabled configuration reports an error
    
    BUG: KASAN: use-after-free in ffs_free_inst+... [usb_f_fs] at addr ...
    Write of size 8 by task ...
    
    This is observed after "ffs-test" is run and interrupted. If after that
    functionfs is unmounted and g_ffs module is unloaded, that use-after-free
    occurs during g_ffs module removal.
    
    Although the report indicates ffs_free_inst() function, the actual
    use-after-free condition occurs in _ffs_free_dev() function, which
    is probably inlined into ffs_free_inst().
    
    This happens due to keeping the ffs_data reference in device structure
    during functionfs unmounting, while ffs_data itself is freed as no longer
    needed. The fix is to clear that reference in ffs_closed() function,
    which is a counterpart of ffs_ready(), where the reference is stored.
    
    Fixes: 3262ad82
    
     ("usb: gadget: f_fs: Stop ffs_closed NULL pointer dereference")
    Cc: stable@vger.kernel.org
    Signed-off-by: default avatarAndrew Gabbasov <andrew_gabbasov@mentor.com>
    Acked-by: default avatarFelipe Balbi <felipe.balbi@linux.intel.com>
    Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
    cdafb6d8