Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
  • Sign in
  • L linux-coresight-backports
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Locked Files
  • Issues 0
    • Issues 0
    • List
    • Boards
    • Service Desk
    • Milestones
    • Iterations
    • Requirements
  • Merge requests 0
    • Merge requests 0
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
    • Test Cases
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Container Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Code review
    • Insights
    • Issue
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • linux-arm
  • linux-coresight-backports
  • Repository
Switch branch/tag
  • linux-coresight-backports
  • fs
  • debugfs
  • inode.c
Find file BlameHistoryPermalink
  • Linus Torvalds's avatar
    Revert "debugfs: inode: debugfs_create_dir uses mode permission from parent" · f5b7769e
    Linus Torvalds authored Jun 12, 2018
    This reverts commit 95cde3c5
    
    .
    
    The commit had good intentions, but it breaks kvm-tool and qemu-kvm.
    
    With it in place, "lkvm run" just fails with
    
      Error: KVM_CREATE_VM ioctl
      Warning: Failed init: kvm__init
    
    which isn't a wonderful error message, but bisection pinpointed the
    problematic commit.
    
    The problem is almost certainly due to the special kvm debugfs entries
    created dynamically by kvm under /sys/kernel/debug/kvm/.  See
    kvm_create_vm_debugfs()
    
    Bisected-and-reported-by: default avatarLinus Torvalds <torvalds@linux-foundation.org>
    Cc: Wanpeng Li <kernellwp@gmail.com>
    Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
    Cc: Thomas Richter <tmricht@linux.ibm.com>
    Cc: Kees Cook <keescook@chromium.org>
    Signed-off-by: default avatarLinus Torvalds <torvalds@linux-foundation.org>
    f5b7769e