Skip to content
  • Nir Dotan's avatar
    mlxsw: spectrum_acl: Remove ASSERT_RTNL()s in module removal flow · 04d075b7
    Nir Dotan authored
    Removal of the mlxsw driver on Spectrum-2 platforms hits an ASSERT_RTNL()
    in Spectrum-2 ACL Bloom filter and in ERP removal paths. This happens
    because the multicast router implementation in Spectrum-2 relies on ACLs.
    Taking the RTNL lock upon driver removal is useless since the driver first
    removes its ports and unregisters from notifiers so concurrent writes
    cannot happen at that time. The assertions were originally put as a
    reminder for future work involving ERP background optimization, but having
    these assertions only during addition serves this purpose as well.
    Therefore remove the ASSERT_RTNL() in both places related to ERP and Bloom
    filter removal.
    Fixes: cf7221a4
     ("mlxsw: spectrum_router: Add Multicast routing support for Spectrum-2")
    Signed-off-by: default avatarNir Dotan <>
    Reviewed-by: default avatarJiri Pirko <>
    Signed-off-by: default avatarIdo Schimmel <>
    Signed-off-by: default avatarDavid S. Miller <>