Skip to content
  • Peter Senna Tschudin's avatar
    drivers/net/ethernet/sun/niu.c: fix error return code · 8c65ef4b
    Peter Senna Tschudin authored
    The function niu_pci_init_one() return 0 for success and negative value
    for most of its internal tests failures. There is one exception
    that is error case going to err_out_free_res:. For this error case, the
    function abort its success execution path, but returns non negative
    value, making it difficult for a caller function to notice the error.
    This patch fixes the error case that do not return negative value.
    This was found by Coccinelle, but the code change was made by hand.
    This patch is not robot generated.
    A simplified version of the semantic match that finds this problem is
    as follows: (
    // <smpl>
    if@p1 (\(ret < 0\|ret != 0\))
     { ... return ret; }
    ret@p1 = 0
    ... when != ret = e1
        when != &ret
      ... when != ret = e2
          when forall
     return ret;
    // </smpl>
    Signed-off-by: default avatarPeter Senna Tschudin <>
    Signed-off-by: default avatarDavid S. Miller <>