tty: Don't block on IO when ldisc change is pending
There might be situations where tty_ldisc_lock() has blocked, but there is already IO on tty and it prevents line discipline changes. It might theoretically turn into dead-lock. Basically, provide more priority to pending tty_ldisc_lock() than to servicing reads/writes over tty. User-visible issue was reported by Mikulas where on pa-risc with Debian 5 reboot took either 80 seconds, 3 minutes or 3:25 after proper locking in tty_reopen(). Cc: Jiri Slaby <jslaby@suse.com> Reported-by:Mikulas Patocka <mpatocka@redhat.com> Signed-off-by:
Dmitry Safonov <dima@arista.com> Signed-off-by:
Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Showing
- drivers/tty/n_hdlc.c 2 additions, 2 deletionsdrivers/tty/n_hdlc.c
- drivers/tty/n_r3964.c 1 addition, 1 deletiondrivers/tty/n_r3964.c
- drivers/tty/n_tty.c 4 additions, 4 deletionsdrivers/tty/n_tty.c
- drivers/tty/tty_ldisc.c 7 additions, 0 deletionsdrivers/tty/tty_ldisc.c
- include/linux/tty.h 7 additions, 0 deletionsinclude/linux/tty.h
Loading
Please register or sign in to comment