Skip to content
  • Gustavo A. R. Silva's avatar
    firewire: mark expected switch fall-throughs · eba6120d
    Gustavo A. R. Silva authored
    In preparation to enabling -Wimplicit-fallthrough, mark switch
    cases where we are expecting to fall through.
    
    This patch fixes the following warnings:
    
    drivers/firewire/core-device.c: In function ‘set_broadcast_channel’:
    drivers/firewire/core-device.c:969:7: warning: this statement may fall through [-Wimplicit-fallthrough=]
        if (data & cpu_to_be32(1 << 31)) {
           ^
    drivers/firewire/core-device.c:974:3: note: here
       case RCODE_ADDRESS_ERROR:
       ^~~~
    drivers/firewire/core-iso.c: In function ‘manage_channel’:
    drivers/firewire/core-iso.c:308:7: warning: this statement may fall through [-Wimplicit-fallthrough=]
        if ((data[0] & bit) == (data[1] & bit))
           ^
    drivers/firewire/core-iso.c:312:3: note: here
       default:
       ^~~~~~~
    drivers/firewire/core-topology.c: In function ‘count_ports’:
    drivers/firewire/core-topology.c:69:23: warning: this statement may fall through [-Wimplicit-fallthrough=]
        (*child_port_count)++;
        ~~~~~~~~~~~~~~~~~~~^~...
    eba6120d