Skip to content
  • Arjan van de Ven's avatar
    x86: Turn the copy_from_user check into an (optional) compile time warning · 4a312769
    Arjan van de Ven authored
    
    
    A previous patch added the buffer size check to copy_from_user().
    
    One of the things learned from analyzing the result of the previous
    patch is that in general, gcc is really good at proving that the
    code contains sufficient security checks to not need to do a
    runtime check. But that for those cases where gcc could not prove
    this, there was a relatively high percentage of real security
    issues.
    
    This patch turns the case of "gcc cannot prove" into a compile time
    warning, as long as a sufficiently new gcc is in use that supports
    this. The objective is that these warnings will trigger developers
    checking new cases out before a security hole enters a linux kernel
    release.
    
    Signed-off-by: default avatarArjan van de Ven <arjan@linux.intel.com>
    Cc: Linus Torvalds <torvalds@linux-foundation.org>
    Cc: "David S. Miller" <davem@davemloft.net>
    Cc: James Morris <jmorris@namei.org>
    Cc: Jan Beulich <jbeulich@novell.com>
    LKML-Reference: <20090930130523.348ae6c4@infradead.org>
    Signed-off-by: default avatarIngo Molnar <mingo@elte.hu>
    4a312769