Skip to content
  • Lv Zheng's avatar
    ACPI: Clean up inclusions of ACPI header files · 8b48463f
    Lv Zheng authored
    Replace direct inclusions of <acpi/acpi.h>, <acpi/acpi_bus.h> and
    <acpi/acpi_drivers.h>, which are incorrect, with <linux/acpi.h>
    inclusions and remove some inclusions of those files that aren't
    First of all, <acpi/acpi.h>, <acpi/acpi_bus.h> and <acpi/acpi_drivers.h>
    should not be included directly from any files that are built for
    CONFIG_ACPI unset, because that generally leads to build warnings about
    undefined symbols in !CONFIG_ACPI builds.  For CONFIG_ACPI set,
    <linux/acpi.h> includes those files and for CONFIG_ACPI unset it
    provides stub ACPI symbols to be used in that case.
    Second, there are ordering dependencies between those files that always
    have to be met.  Namely, it is required that <acpi/acpi_bus.h> be included
    prior to <acpi/acpi_drivers.h> so that the acpi_pci_root declarations the
    latter depends on are always there.  And <acpi/acpi.h> which provides
    basic ACPICA type declarations should always be included prior to any other
    ACPI headers in CONFIG_ACPI builds.  That also is taken care of including
    <linux/acpi.h> as appropriate.
    Signed-off-by: default avatarLv Zheng <>
    Cc: Greg Kroah-Hartman <>
    Cc: Matthew Garrett <>
    Cc: Tony Luck <>
    Cc: "H. Peter Anvin" <>
    Acked-by: Bjorn Helgaas <> (drivers/pci stuff)
    Acked-by: Konrad Rzeszutek Wilk <> (Xen stuff)
    Signed-off-by: default avatarRafael J. Wysocki <>