• Vladimir Davydov's avatar
    mm/slab_common.c: do not warn that cache is busy on destroy more than once · cd918c55
    Vladimir Davydov authored
    Currently, when kmem_cache_destroy() is called for a global cache, we
    print a warning for each per memcg cache attached to it that has active
    objects (see shutdown_cache).  This is redundant, because it gives no new
    information and only clutters the log.  If a cache being destroyed has
    active objects, there must be a memory leak in the module that created the
    cache, and it does not matter if the cache was used by users in memory
    cgroups or not.
    This patch moves the warning from shutdown_cache(), which is called for
    shutting down both global and per memcg caches, to kmem_cache_destroy(),
    so that the warning is only printed once if there are objects left in the
    cache being destroyed.
    Signed-off-by: default avatarVladimir Davydov <vdavydov@virtuozzo.com>
    Cc: Christoph Lameter <cl@linux.com>
    Cc: Pekka Enberg <penberg@kernel.org>
    Cc: David Rientjes <rientjes@google.com>
    Cc: Joonsoo Kim <iamjoonsoo.kim@lge.com>
    Signed-off-by: default avatarAndrew Morton <akpm@linux-foundation.org>
    Signed-off-by: default avatarLinus Torvalds <torvalds@linux-foundation.org>