Skip to content
  • Ingo Molnar's avatar
    Revert "x86/jump-labels: Macrofy inline assembly code to work around GCC inlining bugs" · e769742d
    Ingo Molnar authored
    This reverts commit 5bdcd510
    
    .
    
    The macro based workarounds for GCC's inlining bugs caused regressions: distcc
    and other distro build setups broke, and the fixes are not easy nor will they
    solve regressions on already existing installations.
    
    So we are reverting this patch and the 8 followup patches.
    
    What makes this revert easier is that GCC9 will likely include the new 'asm inline'
    syntax that makes inlining of assembly blocks a lot more robust.
    
    This is a superior method to any macro based hackeries - and might even be
    backported to GCC8, which would make all modern distros get the inlining
    fixes as well.
    
    Many thanks to Masahiro Yamada and others for helping sort out these problems.
    
    Reported-by: default avatarMasahiro Yamada <yamada.masahiro@socionext.com>
    Reviewed-by: default avatarBorislav Petkov <bp@alien8.de>
    Reviewed-by: default avatarThomas Gleixner <tglx@linutronix.de>
    Cc: Juergen Gross <jgross@suse.com>
    Cc: Richard Biener <rguenther@suse.de>
    Cc: Kees Cook <keescook@chromium.org>
    Cc: Segher Boessenkool <segher@kernel.crashing.org>
    Cc: Ard Biesheuvel <ard.biesheuvel@linaro.org>
    Cc: Peter Zijlstra <peterz@infradead.org>
    Cc: Josh Poimboeuf <jpoimboe@redhat.com>
    Cc: Nadav Amit <namit@vmware.com>
    Cc: Linus Torvalds <torvalds@linux-foundation.org>
    Cc: linux-kernel@vger.kernel.org
    Signed-off-by: default avatarIngo Molnar <mingo@kernel.org>
    e769742d