Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
  • Sign in
  • L linux-iv
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Locked Files
  • Issues 0
    • Issues 0
    • List
    • Boards
    • Service Desk
    • Milestones
    • Iterations
    • Requirements
  • Merge requests 0
    • Merge requests 0
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
    • Test Cases
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Container Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Code review
    • Insights
    • Issue
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • linux-arm
  • linux-iv
  • Repository
Switch branch/tag
  • linux-iv
  • drivers
  • virtio
  • virtio_pci_common.c
Find file BlameHistoryPermalink
  • Jason Wang's avatar
    virtio_pci: fix out of bound access for msix_names · de85ec8b
    Jason Wang authored Mar 23, 2017
    Fedora has received multiple reports of crashes when running
    4.11 as a guest
    
    https://bugzilla.redhat.com/show_bug.cgi?id=1430297
    https://bugzilla.redhat.com/show_bug.cgi?id=1434462
    https://bugzilla.kernel.org/show_bug.cgi?id=194911
    https://bugzilla.redhat.com/show_bug.cgi?id=1433899
    
    The crashes are not always consistent but they are generally
    some flavor of oops or GPF in virtio related code. Multiple people
    have done bisections (Thank you Thorsten Leemhuis and
    Richard W.M. Jones) and found this commit to be at fault
    
    07ec5148 is the first bad commit
    commit 07ec5148
    Author: Christoph Hellwig <hch@lst.de>
    Date:   Sun Feb 5 18:15:19 2017 +0100
    
        virtio_pci: use shared interrupts for virtqueues
    
    The issue seems to be an out of bounds access to the msix_names
    array corrupting kernel memory.
    
    Fixes: 07ec5148
    
     ("virtio_pci: use shared interrupts for virtqueues")
    Reported-by: default avatarLaura Abbott <labbott@redhat.com>
    Signed-off-by: default avatarJason Wang <jasowang@redhat.com>
    Signed-off-by: default avatarMichael S. Tsirkin <mst@redhat.com>
    Reviewed-by: default avatarChristoph Hellwig <hch@lst.de>
    Tested-by: default avatarRichard W.M. Jones <rjones@redhat.com>
    Tested-by: default avatarThorsten Leemhuis <linux@leemhuis.info>
    de85ec8b