Skip to content
  • Jacob Keller's avatar
    mlx5: reject unsupported external timestamp flags · 2e0645a0
    Jacob Keller authored
    
    
    Fix the mlx5 core PTP support to explicitly reject any future flags that
    get added to the external timestamp request ioctl.
    
    In order to maintain currently functioning code, this patch accepts all
    three current flags. This is because the PTP_RISING_EDGE and
    PTP_FALLING_EDGE flags have unclear semantics and each driver seems to
    have interpreted them slightly differently.
    
    [ RC: I'm not 100% sure what this driver does, but if I'm not wrong it
          follows the dp83640:
    
      flags                                                 Meaning
      ----------------------------------------------------  --------------------------
      PTP_ENABLE_FEATURE                                    Time stamp rising edge
      PTP_ENABLE_FEATURE|PTP_RISING_EDGE                    Time stamp rising edge
      PTP_ENABLE_FEATURE|PTP_FALLING_EDGE                   Time stamp falling edge
      PTP_ENABLE_FEATURE|PTP_RISING_EDGE|PTP_FALLING_EDGE   Time stamp falling edge
    ]
    
    Cc: Feras Daoud <ferasda@mellanox.com>
    Cc: Eugenia Emantayev <eugenia@mellanox.com>
    Signed-off-by: default avatarJacob Keller <jacob.e.keller@intel.com>
    Reviewed-by: default avatarRichard Cochran <richardcochran@gmail.com>
    Reviewed-by: default avatarSaeed Mahameed <saeedm@mellanox.com>
    Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
    2e0645a0