Skip to content
GitLab
Projects Groups Topics Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
  • Sign in
  • L linux-qy
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributor statistics
    • Graph
    • Compare revisions
    • Locked files
  • Issues 0
    • Issues 0
    • List
    • Boards
    • Service Desk
    • Milestones
    • Iterations
    • Requirements
  • Merge requests 0
    • Merge requests 0
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Artifacts
    • Schedules
    • Test cases
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Container Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • CI/CD
    • Code review
    • Insights
    • Issue
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar

Admin message

The Gitlab will upgrade to latest version for security in the Oct 7th (9:00 ~ 12:00 UTC+8), during the time, the Gitlab site will be offline.

  • linux-arm
  • linux-qy
  • Repository
  • linux-qy
  • drivers
  • net
  • ethernet
  • freescale
  • dpaa2
  • dpaa2-eth.c
Find file BlameHistoryPermalink
  • Sebastian Andrzej Siewior's avatar
    dpaa2-eth: Remove preempt_disable() from seed_pool() · f9dae555
    Sebastian Andrzej Siewior authored Jun 07, 2019
    According to the comment, the preempt_disable() statement is required
    due to synchronisation in napi_alloc_frag(). The awful truth is that
    local_bh_disable() is required because otherwise the NAPI poll callback
    can be invoked while the open function setup buffers. This isn't
    unlikely since the dpaa2 provides multiple devices.
    
    The usage of napi_alloc_frag() has been removed in commit
    
     27c87486
    
     ("dpaa2-eth: Use a single page per Rx buffer")
    
    which means that the comment is not accurate and the preempt_disable()
    statement is not required.
    
    Remove the outdated comment and the no longer required
    preempt_disable().
    
    Cc: Ioana Radulescu <ruxandra.radulescu@nxp.com>
    Acked-by: default avatarIoana Radulescu <ruxandra.radulescu@nxp.com>
    Signed-off-by: default avatarSebastian Andrzej Siewior <bigeasy@linutronix.de>
    Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
    f9dae555