Commit ec438699 authored by Tejun Heo's avatar Tejun Heo Committed by Jens Axboe
Browse files

cgroup, block: implement task_get_css() and use it in bio_associate_current()

bio_associate_current() currently open codes task_css() and
css_tryget_online() to find and pin $current's blkcg css.  Abstract it
into task_get_css() which is implemented from cgroup side.  As a task
is always associated with an online css for every subsystem except
while the css_set update is propagating, task_get_css() retries till
css_tryget_online() succeeds.

This is a cleanup and shouldn't lead to noticeable behavior changes.
Signed-off-by: default avatarTejun Heo <>
Cc: Li Zefan <>
Cc: Jens Axboe <>
Cc: Vivek Goyal <>
Signed-off-by: default avatarJens Axboe <>
parent 496d5e75
......@@ -2004,7 +2004,6 @@ EXPORT_SYMBOL(bioset_create_nobvec);
int bio_associate_current(struct bio *bio)
struct io_context *ioc;
struct cgroup_subsys_state *css;
if (bio->bi_ioc)
return -EBUSY;
......@@ -2013,17 +2012,9 @@ int bio_associate_current(struct bio *bio)
if (!ioc)
return -ENOENT;
/* acquire active ref on @ioc and associate */
bio->bi_ioc = ioc;
/* associate blkcg if exists */
css = task_css(current, blkio_cgrp_id);
if (css && css_tryget_online(css))
bio->bi_css = css;
bio->bi_css = task_get_css(current, blkio_cgrp_id);
return 0;
......@@ -773,6 +773,31 @@ static inline struct cgroup_subsys_state *task_css(struct task_struct *task,
return task_css_check(task, subsys_id, false);
* task_get_css - find and get the css for (task, subsys)
* @task: the target task
* @subsys_id: the target subsystem ID
* Find the css for the (@task, @subsys_id) combination, increment a
* reference on and return it. This function is guaranteed to return a
* valid css.
static inline struct cgroup_subsys_state *
task_get_css(struct task_struct *task, int subsys_id)
struct cgroup_subsys_state *css;
while (true) {
css = task_css(task, subsys_id);
if (likely(css_tryget_online(css)))
return css;
* task_css_is_root - test whether a task belongs to the root css
* @task: the target task
Supports Markdown
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment