Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
  • Sign in
  • L linux-rm
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Locked Files
  • Issues 0
    • Issues 0
    • List
    • Boards
    • Service Desk
    • Milestones
    • Iterations
    • Requirements
  • Merge requests 0
    • Merge requests 0
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
    • Test Cases
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Container Registry
  • Monitor
    • Monitor
    • Metrics
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Code review
    • Insights
    • Issue
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • linux-arm
  • linux-rm
  • Repository
Switch branch/tag
  • linux-rm
  • tools
  • build
  • Makefile
Find file BlameHistoryPermalink
  • James Clark's avatar
    tools build: Fix feature detect clean for out of source builds · 8af52e69
    James Clark authored Aug 16, 2021
    Currently the clean target when using O= isn't cleaning the feature
    detect output. This is because O= and OUTPUT= are set to canonical
    paths. For example in tools/perf/Makefile:
    
      FULL_O := $(shell cd $(PWD); readlink -f $(O) || echo $(O))
    
    This means that OUTPUT ends in a / and most usages prepend it to a file
    without adding an extra /. This line that was changed adds an extra /
    before the 'feature' folder but not to the end, resulting in a clean
    command like this:
    
      rm -f /tmp/build//featuretest-all.bin ...
    
    After the change the clean command looks like this:
    
      rm -f /tmp/build/feature/test-all.bin ...
    
    Fixes: 762323eb
    
     ("perf build: Move feature cleanup under tools/build")
    Signed-off-by: James Clark's avatarJames Clark <james.clark@arm.com>
    Acked-by: default avatarJiri Olsa <jolsa@kernel.org>
    Link: http://lore.kernel.org/lkml/20210816130705.1331868-1-james.clark@arm.com
    
    
    Signed-off-by: default avatarArnaldo Carvalho de Melo <acme@redhat.com>
    8af52e69