Skip to content
  • dingtianhong's avatar
    bonding: fail_over_mac should only affect AB mode at enslave and removal processing · 00503b6f
    dingtianhong authored
    According to bonding.txt, the fail_over_ma should only affect active-backup mode,
    but I found that the fail_over_mac could be set to active or follow in all
    modes, this will cause new slave could not be set to bond's MAC address at
    enslave processing and restore its own MAC address at removal processing.
    The correct way to fix the problem is that we should not add restrictions when
    setting options, just need to modify the bond enslave and removal processing
    to check the mode in addition to fail_over_mac when setting a slave's MAC during
    enslavement. The change active slave processing already only calls the fail_over_mac
    function when in active-backup mode.
    Thanks for Jay's suggestion.
    The patch also modify the pr_warning() to pr_warn().
    Cc: Jay Vosburgh <>
    Cc: Veaceslav Falico <>
    Cc: Andy Gospodarek <>
    Signed-off-by: default avatarDing Tianhong <>
    Signed-off-by: default avatarDavid S. Miller <>