Skip to content
  • Wang Chen's avatar
    bonding: Check return of dev_set_promiscuity/allmulti · 7e1a1ac1
    Wang Chen authored
    dev_set_promiscuity/allmulti might overflow.
    Commit: "netdevice: Fix promiscuity and allmulti overflow" in net-next makes
    dev_set_promiscuity/allmulti return error number if overflow happened.
    In bond_alb and bond_main, we check all positive increment for promiscuity
    and allmulti to get error return.
    But there are still two problems left.
    1. Some code path has no mechanism to signal errors upstream.
    2. If there are multi slaves, it's hard to tell which slaves increment
       promisc/allmulti successfully and which failed.
    So I left these problems to be FIXME.
    Fortunately, the overflow is very rare case.
    Signed-off-by: default avatarWang Chen <>
    Signed-off-by: default avatarDavid S. Miller <>