Verified Commit 82934882 authored by Srinivas Kandagatla's avatar Srinivas Kandagatla Committed by Mark Brown
Browse files

regmap: regmap-irq: fix getting type default values

Checking for value of type default value just after allocating will
always be zero and the type register default values will never be read,
so fix this!

Without this patch setting irq type will be silently ignored.
Patch "regmap: regmap-irq: Remove default irq type setting from core"
did remove the default mask but it forgot to remove the check before
reading the default type register.

Fixes: 84267d1b

 ("regmap: regmap-irq: Remove default irq type setting from core")
Signed-off-by: default avatarSrinivas Kandagatla <>
Signed-off-by: Mark Brown's avatarMark Brown <>
parent 435bba0f
......@@ -664,9 +664,6 @@ int regmap_add_irq_chip(struct regmap *map, int irq, int irq_flags,
if (chip->num_type_reg && !chip->type_in_mask) {
for (i = 0; i < chip->num_type_reg; ++i) {
if (!d->type_buf_def[i])
reg = chip->type_base +
(i * map->reg_stride * d->type_reg_stride);
Supports Markdown
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment