Hi @vstehle,...
Removed all pip install attempts. We now require dt-validate to exist and run cleanly (--version), otherwise we log and exit with an error (no side...
Removed the “assume pass” on fallback failure. Now we log the fallback failure and do not increment pass/error counters silently.
Removed re.compile(...) calls and used plain regex strings with re.search/re.sub so we benefit from the regex cache without extra lines. Behavior i...
Switched back to the project’s run() wrapper and decode stdout/stderr from bytes safely before logging/regex operations. This aligns with the rest ...
Dropped the explicit Optional[str] annotation and kept dt_validate = None so its type is inferred; no functional changes.
Restored the module-level variable name back to parser (the SCT parser command). To avoid shadowing the argparse.ArgumentParser instance, I renamed...
Reverted to strong typing: TreeType = list[FileType | DirType]. This restores the original type intent and keeps mypy strength.
-
2b319e39 · check-sr-results: address review feedback
- ... and 17 more commits. Compare 077d0f60...2b319e39
-
077d0f60 · check-sr-results: address review feedback
-
0d0d1932 · check-sr-results: address review feedback
Sorry I think this should not be merge as it is.
Please don't.
Please don't.
Please do not compile()
regex as this adds more line for no performance gain in our case (thanks to the cache).