Skip to content
Snippets Groups Projects
Sathisha Shivaramappa's avatar
commented on merge request !22 "capsule-tool.py: add multi-payload support for tamper & de-auth (FMP)" at SystemReady / systemready-scripts

Hi @vstehle,...

Sathisha Shivaramappa's avatar
commented on merge request !22 "capsule-tool.py: add multi-payload support for tamper & de-auth (FMP)" at SystemReady / systemready-scripts

Removed all pip install attempts. We now require dt-validate to exist and run cleanly (--version), otherwise we log and exit with an error (no side...

Sathisha Shivaramappa's avatar
commented on merge request !22 "capsule-tool.py: add multi-payload support for tamper & de-auth (FMP)" at SystemReady / systemready-scripts

Removed the “assume pass” on fallback failure. Now we log the fallback failure and do not increment pass/error counters silently.

Sathisha Shivaramappa's avatar
commented on merge request !22 "capsule-tool.py: add multi-payload support for tamper & de-auth (FMP)" at SystemReady / systemready-scripts

Removed re.compile(...) calls and used plain regex strings with re.search/re.sub so we benefit from the regex cache without extra lines. Behavior i...

Sathisha Shivaramappa's avatar
commented on merge request !22 "capsule-tool.py: add multi-payload support for tamper & de-auth (FMP)" at SystemReady / systemready-scripts

Switched back to the project’s run() wrapper and decode stdout/stderr from bytes safely before logging/regex operations. This aligns with the rest ...

Sathisha Shivaramappa's avatar
commented on merge request !22 "capsule-tool.py: add multi-payload support for tamper & de-auth (FMP)" at SystemReady / systemready-scripts

Dropped the explicit Optional[str] annotation and kept dt_validate = None so its type is inferred; no functional changes.

Sathisha Shivaramappa's avatar
commented on merge request !22 "capsule-tool.py: add multi-payload support for tamper & de-auth (FMP)" at SystemReady / systemready-scripts

Restored the module-level variable name back to parser (the SCT parser command). To avoid shadowing the argparse.ArgumentParser instance, I renamed...

Sathisha Shivaramappa's avatar
commented on merge request !22 "capsule-tool.py: add multi-payload support for tamper & de-auth (FMP)" at SystemReady / systemready-scripts

Reverted to strong typing: TreeType = list[FileType | DirType]. This restores the original type intent and keeps mypy strength.

Vincent Stehle's avatar
deleted branch vincent/try at SystemReady / systemready-scripts
Vincent Stehle's avatar
pushed to branch vincent/try at SystemReady / systemready-scripts
Vincent Stehle's avatar
pushed to branch vincent/try at SystemReady / systemready-scripts
Vincent Stehle's avatar
pushed new branch vincent/try at SystemReady / systemready-scripts
Sathisha Shivaramappa's avatar
Sathisha Shivaramappa's avatar
  • 077d0f60 · check-sr-results: address review feedback
Sathisha Shivaramappa's avatar
  • 0d0d1932 · check-sr-results: address review feedback
Vincent Stehle's avatar
deleted branch vincent/try at SystemReady / systemready-scripts
Vincent Stehle's avatar
commented on merge request !22 "capsule-tool.py: add multi-payload support for tamper & de-auth (FMP)" at SystemReady / systemready-scripts

Sorry I think this should not be merge as it is.

Vincent Stehle's avatar
commented on merge request !22 "capsule-tool.py: add multi-payload support for tamper & de-auth (FMP)" at SystemReady / systemready-scripts

Please don't.

Vincent Stehle's avatar
commented on merge request !22 "capsule-tool.py: add multi-payload support for tamper & de-auth (FMP)" at SystemReady / systemready-scripts

Please don't.

Vincent Stehle's avatar
commented on merge request !22 "capsule-tool.py: add multi-payload support for tamper & de-auth (FMP)" at SystemReady / systemready-scripts

Please do not compile() regex as this adds more line for no performance gain in our case (thanks to the cache).