Pierre Gondois · Douglas Raillard · 763b85f9 · 763b85f9 · 763b85f9 · 763b85f9
--- a/lisa/_assets/kmodules/lisa/configs.c 0 → 100644
+++ b/lisa/_assets/kmodules/lisa/configs.c 0 → 100644
+			 * Feature was enabled, and de-activating this config
+			 * disabled the feature.
+			 */
+			if (feature->__explicitly_enabled && !cfg->activated)
+				deinit_single_features(feature->name);
+			continue;
+		}
+
+		if (cfg->activated) {
+			/*
+			* Feature was enabled. By default, de-init before re-init the feature
+			* to catch potential modifications.
+			*/
+			if (feature->__explicitly_enabled)
+				deinit_single_features(feature->name);
+			init_single_feature(feature->name);
--- a/lisa/_assets/kmodules/lisa/configs.c 0 → 100644
+++ b/lisa/_assets/kmodules/lisa/configs.c 0 → 100644
+			if (new_value)
+				ret = feature_param_remove_config_common(entry);
+			else
+				ret = feature_param_merge_common(entry);
+			if (ret) {
+				pr_err("Could not rollback config values\n");
+				return ret;
+			}
+		}
+	}
+
+	return ret;
+}
+
+static inline
+bool is_feature_set(char *name)
--- a/lisa/_assets/kmodules/lisa/feature_params.c 0 → 100644
+++ b/lisa/_assets/kmodules/lisa/feature_params.c 0 → 100644
+//    feature_param type handlers
+/////////////////////////////////////
+
+static int
+feature_param_set_common(struct feature_param_entry *entry, void *data)
+{
+	struct feature_param_entry_value *val;
+	int ret = 0;
+
+	switch (entry->param->mode) {
+	case FT_PARAM_MODE_SINGLE:
+		/* Single parameter, replace the pre-existing value. */
+		/*
+		 * TODO This might not be a good idea. The value is replaced
+		 * even when the user thinks the value is appended.
+		 * I.e. 'echo 1 >> file' will replace the pre-existing value.
--- a/lisa/_assets/kmodules/lisa/feature_params.h 0 → 100644
+++ b/lisa/_assets/kmodules/lisa/feature_params.h 0 → 100644
+	 * different configs. The resulting value is a set of all the
+	 * values of the different configs.
+	 */
+	FT_PARAM_MODE_SET = 1,
+};
+
+enum feature_param_type {
+	/* Standard parameter. */
+	FT_PARAM_TYPE_STD = 0,
+	/* Specific to the 'lisa_features_param' parameter handling. */
+	FT_PARAM_TYPE_AVAILABLE_FT,
+};
+
+struct feature_param {
+	const char *name;
+	enum feature_param_mode mode;
--- a/lisa/_assets/kmodules/lisa/features.h
+++ b/lisa/_assets/kmodules/lisa/features.h
+int deinit_single_features(char *selected);
+
+/**
+ * find_feature() - Find the (struct feature) matching the input name.
+ * @name: Name of the feature to find.
+ *
+ * Return: (struct feature*) matching the input name if success.
+ * NULL otherwise.
+ */
+struct feature *find_feature(char *name);
+
+/**
+ * find_feature_param() - Find the (struct feature_param) of a feature
+ * matching the input name.
+ * @name: Name of the feature to find.
+ * @feature: Feature to search the (struct feature_param) from.
--- a/lisa/_assets/kmodules/lisa/features.c
+++ b/lisa/_assets/kmodules/lisa/features.c
 int __placeholder_deinit(struct feature *feature) {
 	return 0;
 }
+
+struct feature *find_feature(char *name)
--- a/lisa/_assets/kmodules/lisa/feature_params.h 0 → 100644
+++ b/lisa/_assets/kmodules/lisa/feature_params.h 0 → 100644
+#define PARAM_SINGLE(name, perms, param_type, feature)	\
+	__PARAM(name, FT_PARAM_MODE_SINGLE, FT_PARAM_TYPE_STD, perms, param_type, __EVENT_FEATURE(feature))
+#define PARAM_SET(name, perms, param_type, feature) \
+	__PARAM(name, FT_PARAM_MODE_SET, FT_PARAM_TYPE_STD, perms, param_type, __EVENT_FEATURE(feature))
+
+#define FEATURE_PARAMS(...)				\
+		.params = (struct feature_param* []){__VA_ARGS__, NULL}	\
+
+#define EXPAND(...)	__VA_ARGS__
+#define DEFINE_FEATURE_PARAMS(...) EXPAND(__VA_ARGS__)
+
+#define for_each_feature_param(param, pparam, feature)	\
+	if (feature->params)				\
+		for (pparam = feature->params, param = *pparam; param != NULL; pparam++, param = *pparam)
+
+#define feature_param_entry_print(param, val) {				\